This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Set SpanKind for HTTP and gRPC requests #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
reviewed
Mar 20, 2018
plugin/ocgrpc/client.go
Outdated
| @@ -25,6 +25,8 @@ import ( | |||
| // traces. Use with gRPC clients only. | |||
| type ClientHandler struct { | |||
| // StartOptions allows configuring the StartOptions used to create new spans. | |||
| // | |||
| // SpanKind will always set to SpanKindClient for spans started with this handler. | |||
There was a problem hiding this comment.
will always be set to SpanKindClient for spans started by
plugin/ocgrpc/server.go
Outdated
| @@ -46,6 +46,8 @@ type ServerHandler struct { | |||
| // ensures that each service has some opportunity to be traced. If you would | |||
| // like to not add any additional traces for this gRPC service, set: | |||
| // StartOptions.Sampler = trace.ProbabilitySampler(0.0) | |||
| // | |||
| // SpanKind will always set to SpanKindServer for spans started from this handler. | |||
odeke-em
approved these changes
Mar 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.