This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Span names shouldn't be prefixed with Sent and Recv #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
reviewed
Mar 20, 2018
| } | ||
| return prefix + "." + host + port + u.Path | ||
| func spanNameFromURL(u *url.URL) string { | ||
| return u.Path |
There was a problem hiding this comment.
Will the path be sufficient here?
Requests from "localhost:443/foo", "opencensus.io:8888/foo", "opencensus.io/foo", "ultima.te:9999/foo" will all have the same span name.
There was a problem hiding this comment.
Users should always breakdown by host. Unlike RPC, there is no concept of a service name in HTTP URLs. The hostname might differ even if the service is the same.
Instead set them for some exporters that cannot differentiate client spans from server spans in their model. Fixes census-instrumentation#607.
|
PTAL |
semistrict
approved these changes
Mar 21, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead set them for some exporters that cannot
differentiate client spans from server spans in their model.
Fixes #607.