This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Remove charset restrictions on tag values #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semistrict
force-pushed
the
tag-value-restrictions
branch
from
1af793d
to
e908e49
Compare
odeke-em
approved these changes
Mar 27, 2018
tag/validate.go
Outdated
| @@ -52,5 +52,5 @@ func checkValue(v string) bool { | |||
| if len(v) > maxKeyLength { | |||
| return false | |||
| } | |||
| return isASCII(v) | |||
| return true | |||
There was a problem hiding this comment.
In this case we can fold this entirely into
func checkValue(v string) bool {
return len(v) <= maxKeyLength
}| Insert(k5, "v\x19"), | ||
| Upsert(k5, "v\x19"), | ||
| Update(k5, "v\x19"), | ||
| Insert(k5, strings.Repeat("x", 256)), |
There was a problem hiding this comment.
Perhaps this could be a test of its own since the restriction being newly tested is len(v) <= 255
There was a problem hiding this comment.
added t.Run, so it should appear as it's own test
semistrict
force-pushed
the
tag-value-restrictions
branch
from
e908e49
to
ee94ce0
Compare
Closed
rakyll
added a commit
that referenced
this pull request
Apr 6, 2018
wingyplus
added a commit
to wingyplus/opencensus-go
that referenced
this pull request
Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: census-instrumentation/opencensus-specs#71