Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Export LastValueData to Prometheus and Stackdriver #658

Merged
merged 1 commit into from
Mar 30, 2018
Merged

Export LastValueData to Prometheus and Stackdriver #658

merged 1 commit into from
Mar 30, 2018

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Mar 30, 2018 •
edited
Loading

Fixes #656.

semistrict
semistrict approved these changes Mar 30, 2018
View reviewed changes
exporter/stackdriver/stats.go Outdated
@@ -348,6 +350,10 @@ func newTypedValue(vd *view.View, r *view.Row) *monitoringpb.TypedValue {
BucketCounts: v.CountPerBucket,
},
}}
case *view.LastValueData:
return &monitoringpb.TypedValue{Value: &monitoringpb.TypedValue_DoubleValue{
DoubleValue: float64(v.Value),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this case necessary? Isn't this already a float64?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@rakyll rakyll merged commit 26cab1e into census-instrumentation:master Mar 30, 2018
@rakyll rakyll deleted the lastvaluedata branch March 30, 2018 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@semistrict semistrict semistrict approved these changes

@odeke-em odeke-em Awaiting requested review from odeke-em

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakyll @semistrict