This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Remove vendor directory from .gitignore #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
reviewed
Apr 16, 2018
|
See #703 (comment). I was a little surprised we merged the PR without finishing the discussion, but if you'd like it added back again please let me know and I'll adjust the PR. |
|
Sorry for merging that PR. It was not very obvious to me that they are unaddressed issues. What I meant to say about having a vendor directory is that we vendor thrift at the point and we shouldn't ignore the vendor directory. |
We didn't want it added in the first place, but serendipituously I misspelled the directory the first time around so it was actually never ignored.
johanbrandhorst
force-pushed
the
patch-1
branch
from
937b6b3
to
6f0519d
Compare
johanbrandhorst
changed the title
|
@rakyll sorry for the confusion, I've gone ahead and removed it from .gitignore now 🙂. |
rakyll
approved these changes
Apr 17, 2018
|
Thanks much!!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.