Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Remove Stackdriver exporter #790

Merged

Conversation

semistrict
Copy link
Contributor

@semistrict semistrict commented Jun 15, 2018

The Stackdriver exporter has been moved to a different repo:
https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver

New import path: contrib.go.opencensus.io/exporter/stackdriver

Fixes: #789

@semistrict semistrict requested a review from rakyll June 15, 2018 19:26
@@ -1,82 +0,0 @@
// Copyright 2017, OpenCensus Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question. Is it possible to keep this package with a doc.go and say it has moved to the new location for now?

Then it will break the builds and people will read the godoc and migrate to the new import path. Then, in a few releases, we can delete the package entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will do that.

@odeke-em
Copy link
Member

Could we gradually sunset this change say in a couple of weeks? I ask because OpenCensus has gotten a bunch of attention lately, and this change is going to break a bunch of apps that I and others have freshly pushed out to encourage people to check it out, but also as quick starts. A gradual sunset gives me and others time to go update our source code, say in 2 or 3 weeks? I am currently so busy to go update all my apps instantly.

@semistrict
Copy link
Contributor Author

ok, I will leave the PR open and merge in two weeks.

@jeanbza
Copy link
Contributor

jeanbza commented Aug 1, 2018

Friendly ping - what's the timeline for this?

@rakyll
Copy link
Contributor

rakyll commented Aug 1, 2018

Can we remove this now? goimports automatically picks up this package and confuses the user.

@odeke-em
Copy link
Member

odeke-em commented Aug 2, 2018

Please go ahead @Ramonza, sorry and thanks for the patient wait everyone!

The Stackdriver exporter has been moved to a different repo:
https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver

New import path: contrib.go.opencensus.io/exporter/stackdriver
@semistrict semistrict merged commit df6bd80 into census-instrumentation:master Aug 2, 2018
semistrict pushed a commit to semistrict/opencensus-go that referenced this pull request Aug 2, 2018
@jcgregorio
Copy link

Please revert "Remove Stackdriver exporter" as it breaks google.golang.org/api/transport/http and thus a slew of cloud.google.com packages.

semistrict pushed a commit that referenced this pull request Aug 2, 2018
@jcgregorio
Copy link

Thanks!

semistrict pushed a commit to semistrict/opencensus-go that referenced this pull request Aug 2, 2018
The Stackdriver exporter has been moved to a different repo:
https://github.com/census-ecosystem/opencensus-go-exporter-stackdriver

New import path: contrib.go.opencensus.io/exporter/stackdriver
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants