This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
http out test cases #928
Merged
http out test cases #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semistrict
reviewed
Sep 24, 2018
SergeyKanzhelev
force-pushed
the
sergkanz/experiment
branch
from
9b852aa
to
d440d31
Compare
|
@Ramonza would you mind to look at it, I've refreshed it |
SergeyKanzhelev
requested review from
rakyll,
rghetia and
a team
as code owners
added 2 commits
March 14, 2019 14:42
bogdandrutu
approved these changes
Mar 19, 2019
rghetia
reviewed
Mar 19, 2019
plugin/ochttp/trace_test.go
Outdated
| t.Errorf("span names don't match: expected: %s, actual: %s", tt.SpanName, client.Name) | ||
| } | ||
|
|
||
| codeToStr := map[int32]string{ |
There was a problem hiding this comment.
how about using codeToStr from here
rghetia
approved these changes
Mar 20, 2019
songy23
pushed a commit
that referenced
this pull request
Apr 3, 2019
* http spec test example * support for local-server based spec tests * read test cases from file: * the same test cases file as for C# * moved test cases file to testdata * updated to the lateat spec * attributes * fixed linter errors * fix sync issue * use already defined map instead (cherry picked from commit 7396103)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is example how shared http out test cases can be used across repositories. The JSON can be either downloaded directly from specs repo or copied into this repo periodically with some script.
This PR also makes two changes in actual code:
http.user_agentattribute when it's emptyerrorattribute to spans in case of error like DNS error according to https://github.com/opentracing/specification/blob/master/semantic_conventions.md#span-tags-table