This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add Resource to Span #174
Merged
Add Resource to Span #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #169 |
yurishkuro
reviewed
Jan 23, 2019
| @@ -290,6 +291,11 @@ message Span { | |||
| // Status.Ok (code = 0). | |||
| Status status = 11; | |||
|
|
|||
| // An optional resource that this span describes. If not set, this span | |||
| // should be part of a batch that does include the span information, unless resource | |||
There was a problem hiding this comment.
"that does include the span information" or "that does include the resource information"?
There was a problem hiding this comment.
ah you are right, should be resource. -- fixing
added 2 commits
January 23, 2019 13:20
bogdandrutu
approved these changes
Jan 23, 2019
pjanotti
approved these changes
Jan 23, 2019
rghetia
reviewed
Jan 24, 2019
| @@ -290,6 +291,11 @@ message Span { | |||
| // Status.Ok (code = 0). | |||
| Status status = 11; | |||
|
|
|||
| // An optional resource that this span describes. If not set, this span | |||
There was a problem hiding this comment.
span doesn't describe resource. May be this should be rephrased to something like "An optional resource to which this span is associated with".
There was a problem hiding this comment.
Reworded. Please take another look
bogdandrutu
approved these changes
Jan 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the wider meeting, adds Resource information to individual spans.