Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kwargs to derived gauge #1135

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Add kwargs to derived gauge #1135

merged 2 commits into from
Jun 30, 2022

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Jun 29, 2022

No description provided.

@lzchen lzchen requested review from a team, aabmass, hectorhdzg and songy23 as code owners June 29, 2022 23:42
aabmass
aabmass reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this PR do? I'm not very familiar with this code. It looks like it's unconditionally adding kwargs as labels for the DerivedGauge?

@lzchen
Copy link
Contributor Author

lzchen commented Jun 30, 2022

@aabmass
DerivedGauges generates point value based off of a passed in function. The current design only accepts a function with no args. This PR adds the option to pass in kwargs to the DerivedGauge to execute the function with parameters.

aabmass
aabmass approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, LGTM.

@lzchen lzchen merged commit 8e30d7d into census-instrumentation:master Jun 30, 2022
@lzchen lzchen deleted the gauge branch June 30, 2022 17:37
inirudebwoy pushed a commit to inirudebwoy/opencensus-python that referenced this pull request Jan 11, 2023
@lzchen @inirudebwoy
Add kwargs to derived gauge (census-instrumentation#1135)
4dab4d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabmass aabmass aabmass approved these changes

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg hectorhdzg is a code owner

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzchen @aabmass