Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trace exporter for Datadog #793

Merged
merged 7 commits into from
Oct 4, 2019
Merged

Trace exporter for Datadog #793

merged 7 commits into from
Oct 4, 2019

Conversation

nbutton23
Copy link
Contributor

@nbutton23 nbutton23 commented Sep 30, 2019 •
edited
Loading

Provides a trace exporter for Datadog. This was closely modeled after the DataDog provided Go exporter.

https://github.com/DataDog/opencensus-go-exporter-datadog

@nbutton23
A trace exporter for datadog based off of the go exporter
988890e 
https://github.com/DataDog/opencensus-go-exporter-datadog

WIP - believe that the barebones exportor is working

Working traces

Clean up

move files back to where they go

clean up todo

fix folder name

WIP - start work on getting PR ready

test, lint, and coverage passing

clean up

clean up
@nbutton23
update readme
20e79ba
@nbutton23 nbutton23 requested review from c24t, reyang, songy23 and a team as code owners September 30, 2019 23:59
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Oct 1, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 1, 2019
@reyang
Copy link
Contributor

reyang commented Oct 1, 2019

Please clean the CI.

@nbutton23
Copy link
Contributor Author

@reyang I am new to python and might need a little help with understanding how to fix the travis-ci. Running nox locally works. . .

@lzchen
Copy link
Contributor

lzchen commented Oct 1, 2019

@nbutton23
We use nox to run our CircleCI build, while tox is responsible for our TravisCI build (confusing I know). Taking a look at the errors from your build, it looks like it cannot find the dependency for your extension when running the tests in the virtual environment. Installing the datadog extension should solve it.

Add py{27,34,35,36,37}-unit,py37-lint: -e contrib/opencensus-ext-datadog to tox.ini file under deps.

@nbutton23 nbutton23 requested a review from reyang October 3, 2019 16:34
@reyang reyang merged commit 3f01007 into census-instrumentation:master Oct 4, 2019
@reyang
Copy link
Contributor

reyang commented Oct 4, 2019

Thanks for your contribution @nbutton23!
Welcome to Python and OpenCensus 😄

@reyang
Copy link
Contributor

reyang commented Oct 4, 2019

@nbutton23 it'll be great to have an README.rst file as other extension packages do. This file will be published to PyPI so people can see the docs. You may refer to https://pypi.org/project/opencensus-ext-azure/ and https://github.com/census-instrumentation/opencensus-python/tree/master/contrib/opencensus-ext-azure.

@lzchen lzchen mentioned this pull request Oct 4, 2019
Merged
maeserichar pushed a commit to maeserichar/opencensus-python that referenced this pull request Oct 5, 2019
@nbutton23 @maeserichar
Trace exporter for Datadog (census-instrumentation#793)
96b18df
@nbutton23 nbutton23 deleted the nbutton-dd-exportor branch October 7, 2019 14:22
@nbutton23
Copy link
Contributor Author

@reyang I opened a new PR for the docs #799

@lzchen lzchen mentioned this pull request Nov 18, 2019
Merged
@RenaultAI RenaultAI mentioned this pull request Jan 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen left review comments

@reyang reyang reyang approved these changes

@c24t c24t Awaiting requested review from c24t

@songy23 songy23 Awaiting requested review from songy23

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbutton23 @googlebot @reyang @lzchen