Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete docs to redirect #666

Merged
merged 9 commits into from
Apr 4, 2024

Conversation

mateusz-001
Copy link
Contributor

@mateusz-001 mateusz-001 commented Apr 3, 2024

Changelog entry

  • removed docs files to make redirections working. External redirections in Grav CMS are working only when page you are trying to visit hasn't any content. Here is spreadsheet with all redirections

Here is an example:
I have two redirections, for `/typography` and `/centra-sections`. Redirection for `/typography` doesn’t work, because we have content. For `/centra-sections` works, because we haven’t content there
Screen.Recording.2024-03-29.at.12.36.17.mov

@mateusz-001 mateusz-001 self-assigned this Apr 3, 2024
@rebzden-centra
Copy link

Let's just add a comment in the readme so that when I search for _moved in the project I can see the reasoning for this change :)

@mateusz-001
Copy link
Contributor Author

Let's just add a comment in the readme so that when I search for _moved in the project I can see the reasoning for this change :)

Added it 😄

@remziatay
Copy link

Is there a special reason not to delete these folders completely?

@remziatay
Copy link

What about these files?

/04.guides/chapter.md
/05.api-references/chapter.md
/05.api-references/03.checkout-api/chapter.md
/05.api-references/03.checkout-api/02.api-reference/chapter.md
/05.api-references/04.shop-api/chapter.md

image

image

@mateusz-001
Copy link
Contributor Author

Is there a special reason not to delete these folders completely?

Not really, but I'd like to keep it, maybe someone will want to get back to previous versions

@mateusz-001
Copy link
Contributor Author

What about these files?

/04.guides/chapter.md
/05.api-references/chapter.md
/05.api-references/03.checkout-api/chapter.md
/05.api-references/03.checkout-api/02.api-reference/chapter.md
/05.api-references/04.shop-api/chapter.md

image

image

They are missing in spreadsheet, but I see we can do redirects for them.

@remziatay
Copy link

Not really, but I'd like to keep it, maybe someone will want to get back to previous versions

If someone wants to get back, they can use git history. That's why we have version control 😄
If you can estimate an amount of time these files could be useful for people, maybe create a task to delete them so it won't be forgotten. Otherwise let's just remove them

config/site.yaml Outdated Show resolved Hide resolved
config/site.yaml Show resolved Hide resolved
@remziatay
Copy link

One place missed /fe-development/payments

@mateusz-001
Copy link
Contributor Author

One place missed /fe-development/payments

Changed it 😄

@mateusz-001 mateusz-001 merged commit 234f1d4 into master Apr 4, 2024
1 check failed
@mateusz-001 mateusz-001 deleted the chore/add-_moved-to-redirected-docs branch April 4, 2024 09:32
@mateusz-001 mateusz-001 changed the title chore: add _moved to redirected docs chore: delete docs to redirect Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants