Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update volumes.pm: add ex4100 support #4807

Closed
wants to merge 2 commits into from

Conversation

joschi99
Copy link
Contributor

@joschi99 joschi99 commented Jan 4, 2024

#4804

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 22.04.x
  • 22.10.x
  • 23.04.x
  • 23.10.x
  • 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@joschi99 joschi99 requested a review from a team as a code owner January 4, 2024 18:10
@joschi99
Copy link
Contributor Author

Hi @omercier,
did you evaluate this pull requests to add support for ex4100? We have done tests and it works fine

@omercier
Copy link
Contributor

Hi @joschi99,
No, not yet, sorry.

@omercier
Copy link
Contributor

omercier commented Mar 4, 2024

Hi @joschi99,

Thanks for the contribution 💯
Your contribution will be discussed during the next weekly sessions of refinement with the team alongside with #4806 and #4805
Thanks 👍

Regards,

@lucie-dubrunfaut
Copy link
Contributor

Hello :)

Thanks for the contribution 🙏
To help us integrate it can you provide some data test to help us for adding automated test on it? (an snmpwalk or only the part of it that allows testing it)

@lucie-dubrunfaut
Copy link
Contributor

Hello :)

This PR and the two others about this plugin are currently waiting to have the data (snmpwalk) concerning the volume mode in order to be able to generate the associated automated tests.

@joschi99
Copy link
Contributor Author

joschi99 commented Jul 5, 2024

Here you can find a full snmp walk
nas-wd.txt

@lucie-dubrunfaut
Copy link
Contributor

Rebase internally here : #5191
Thanks for the contribution 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants