Remove old migrations for development 1047 #1840
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
Q0-trivial
lemunozm
commented
May 20, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "development-runtime" | |||
| version = "0.10.46" | |||
There was a problem hiding this comment.
We had this not updated, although I guess it's not a problem
There was a problem hiding this comment.
Unfortunately, this often falls short but it doesn't have any effect anyways.
|
Can we merge this soon in order to avoid some issues in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1840 +/- ##
==========================================
+ Coverage 46.87% 46.89% +0.02%
==========================================
Files 165 165
Lines 12950 12948 -2
==========================================
+ Hits 6070 6072 +2
+ Misses 6880 6876 -4 ☔ View full report in Codecov by Sentry. |
lemunozm
force-pushed
the
clean/old-migrations
branch
from
ef5af4d
to
7cbbb9c
Compare
wischli
reviewed
May 21, 2024
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "development-runtime" | |||
| version = "0.10.46" | |||
There was a problem hiding this comment.
Unfortunately, this often falls short but it doesn't have any effect anyways.
|
Ok 👍🏻 Finally, it's not urgent for me for the upgrade by now, so we can leave this here |
lemunozm
added
P5-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Double check it's no longer needed please.