Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup from rbox -> mdbox : #220

Closed
jrse opened this issue Dec 4, 2018 · 1 comment
Closed

backup from rbox -> mdbox : #220

jrse opened this issue Dec 4, 2018 · 1 comment
Assignees
Labels

Comments

@jrse
Copy link
Contributor

jrse commented Dec 4, 2018

dsync(t1): Warning: no value for metadata 'P' found
dsync(t1): Warning: no value for metadata 'O' found

@jrse jrse self-assigned this Dec 4, 2018
@jrse
Copy link
Contributor Author

jrse commented Dec 4, 2018

Metadata 'O' = RBOX_METADATA_POP3_ORDER
Metadata 'P' = RBOX_METADATA_POP3_UIDL

Source of this warning is rbox_mail.cpp
rbox_mail_metadata_get(...)
...
rmail->rados_mail->get_metadata(key, &value);
if (!value.empty()) {
*value_r = i_strdup(value.c_str());
} else {
i_warning("no value for metadata '%c' found ", static_cast(key));
}
...

rbox_save.cpp
rbox_save_mail_set_metadata(...)
...
if (r_storage->config->is_mail_attribute(rbox_metadata_key::RBOX_METADATA_POP3_UIDL)) {
if (mdata->pop3_uidl != NULL) {
RadosMetadata xattr(rbox_metadata_key::RBOX_METADATA_POP3_UIDL, mdata->pop3_uidl);
mail_object->add_metadata(xattr);
}
}
if (r_storage->config->is_mail_attribute(rbox_metadata_key::RBOX_METADATA_POP3_ORDER)) {
if (mdata->pop3_order != 0) {
RadosMetadata xattr(rbox_metadata_key::RBOX_METADATA_POP3_ORDER, mdata->pop3_order);
mail_object->add_metadata(xattr);
}
}
...

jrse added a commit that referenced this issue Dec 4, 2018
…et, rbox_save will not create a omap key:value for this.
@jrse jrse closed this as completed Dec 4, 2018
jrse added a commit that referenced this issue Dec 4, 2018
#220: added #ifdef around the warning message. If a metadata is not s…
@jrse jrse added the bug label Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant