Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integrate googlemock #75

Closed
jrse opened this issue Sep 5, 2017 · 0 comments
Closed

integrate googlemock #75

jrse opened this issue Sep 5, 2017 · 0 comments
Assignees
@jrse

Comments

@jrse
Copy link
Contributor

jrse commented Sep 5, 2017

add googlemock to unittests.
@jrse jrse self-assigned this Sep 5, 2017
@jrse jrse closed this as completed Sep 8, 2017
peter-mauritius pushed a commit that referenced this issue Sep 8, 2017
@jrse
#75 added googlemock
a6e9b65
peter-mauritius pushed a commit that referenced this issue Sep 8, 2017
@jrse
#75 added interfaces for radosdict, radosstorage, rados cluster
ab9a4de 
- dovecot storage now uses interfaces.
  rados-cluster-interface, rados-dictionary-interface,
rados-storage-interface. 
- struct rbox_storage now uses RadosCluster* and RadosStorage*
- rbox-storage.cpp rbox_storage_alloc creates RadosStorage and
RadosCluster. rbox-storage.cpp rbox_storage_destroy tears them down.
- added mock classes (radosStorageMock,
RadosClusterMock,RadosDictionaryMock) in tests/mock
- added basic test with StorageMock to eval mock is working
- changed RadosCluster interface. moved open_connection to storage. 
- redirected several calls from dovecot to io_ctx to storage->io_ctx to
avoid using io_ctx directly. (rbox-copy still uses io_ctx).
peter-mauritius pushed a commit that referenced this issue Sep 8, 2017
@jrse
#75 removed RadosStorage forward declaration.
4c0f24a
peter-mauritius pushed a commit that referenced this issue Sep 8, 2017
@jrse
#75 googlemock test rados connection not available (save_mail)
fa26f1c 
- unit test to eval behavior, if connection to rados is not successfull.
- fixed rollback bug. (open_connection fct. moved to save_finish)
peter-mauritius pushed a commit that referenced this issue Sep 8, 2017
@jrse
#75 removed create_dictionary from RadosCluster
5cf4478 
RadosCluster gets now injected (constructur) to RadosDictionaryImpl
peter-mauritius pushed a commit that referenced this issue Sep 8, 2017
@jrse
#75 io_ctx.close() moved to Rados-cluster.deinit()
9b22935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrse jrse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrse