Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read mail, unnecessary stat? #79

Closed
jrse opened this issue Sep 16, 2017 · 0 comments
Closed

read mail, unnecessary stat? #79

jrse opened this issue Sep 16, 2017 · 0 comments
Assignees
@jrse
Labels
enhancement

Comments

@jrse
Copy link
Contributor

jrse commented Sep 16, 2017

currently we do an additional rados stat operation before we read the mail object from rados (rbox-mail.cpp, rbox_mail_get_stream()). We do this to determine the size of the ostream( buffer ). This may be unnecessary.
@jrse jrse changed the title read mail read mail unnecessary stat? Sep 16, 2017
@jrse jrse changed the title read mail unnecessary stat? read mail, unnecessary stat? Sep 16, 2017
@jrse jrse self-assigned this Sep 26, 2017
jrse added a commit that referenced this issue Sep 26, 2017
@jrse
#79 unnecessary stat in rbox_mail_get_stream
724901f 
it is not necessary to do a additional stat to determine the object
size, it is sufficient to read the object with max int size from rados.

- changed interface method read_mail
- replaced bufferlist.copy with memcpy.
- removed memset call for read_buffer.
- changed librmb_unit test to eval read_mail.
jrse added a commit that referenced this issue Sep 26, 2017
@jrse
#79 memcpy librados::bufferlist c_str() to char buffer
7ef9fa1
@jrse jrse closed this as completed Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrse jrse

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrse