fixes for g++ and clang++ compiler warnings #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rados-metadata-storage-ima.cpp:39:19: warning: declaration shadows a static data member of 'librmb::RadosMetadataStorageIma' [-Wshadow]
std::string keyword_key;
^
rados-metadata-storage-ima.cpp:18:38: note: previous declaration is here
std::string RadosMetadataStorageIma::keyword_key = "K";
^
Signed-off-by: Danny Al-Gaaf <[email protected]>
rmb.cpp:193:26: warning: function 'usage_exit' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
static void usage_exit() {
^
Signed-off-by: Danny Al-Gaaf <[email protected]>
dict-rados.cpp:625:12: error: expected a qualified name after 'typename'
typename map<string, bufferlist>::iterator map_iter;
^
dict-rados.cpp:625:12: error: duplicate member 'map'
dict-rados.cpp:624:32: note: previous declaration is here
std::map<string, bufferlist> map;
^
dict-rados.cpp:625:15: error: expected ';' at end of declaration list
typename map<string, bufferlist>::iterator map_iter;
^
Signed-off-by: Danny Al-Gaaf <[email protected]>
Fix for:
rados-util.cpp:101:14: warning: 'omap_get_keys' is deprecated [-Wdeprecated-declarations]
first_read.omap_get_keys("", LONG_MAX, &extended_keys, &err);
^
/usr/include/rados/librados.hpp:594:52: note: 'omap_get_keys' has been explicitly marked deprecated here
int *prval) __attribute__ ((deprecated)); // use v2
^
dict-rados.cpp:713:27: warning: 'omap_get_vals' is deprecated [-Wdeprecated-declarations]
private_read_op.omap_get_vals("", k, LONG_MAX, &iter->results.back().map, &iter->results.back().rval);
^
/usr/include/rados/librados.hpp:558:35: note: 'omap_get_vals' has been explicitly marked deprecated here
int *prval) __attribute__ ((deprecated)); // use v2
^
dict-rados.cpp:740:26: warning: 'omap_get_vals' is deprecated [-Wdeprecated-declarations]
shared_read_op.omap_get_vals("", k, LONG_MAX, &iter->results.back().map, &iter->results.back().rval);
^
/usr/include/rados/librados.hpp:558:35: note: 'omap_get_vals' has been explicitly marked deprecated here
int *prval) __attribute__ ((deprecated)); // use v2
^
Signed-off-by: Danny Al-Gaaf <[email protected]>
peter-mauritius
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wshadow