Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed regex, due to build issues on suse server #160

Merged
merged 3 commits into from
Jun 4, 2018

Conversation

jrse
Copy link
Contributor

@jrse jrse commented Jun 2, 2018

No description provided.

peter-mauritius
peter-mauritius previously approved these changes Jun 4, 2018
Copy link
Collaborator

@peter-mauritius peter-mauritius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we should require a newer compiler version in the future.

@jrse jrse force-pushed the jrse_20180601_suse_build branch from cc3124f to 8667003 Compare June 4, 2018 07:49
@peter-mauritius peter-mauritius merged commit 5cf6590 into master Jun 4, 2018
@jrse jrse deleted the jrse_20180601_suse_build branch June 4, 2018 09:02
@dalgaaf
Copy link
Collaborator

dalgaaf commented Jun 6, 2018

@jrse shouldn't this better be managed in a configure check and have a ifdef handling the regex code in case the compiler/library version is right? Especially since the issue exists only on SLE12-SP3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants