Jrse #182 #186
Merged
Jrse #182 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- backup all valid mail objects to the other mailbox format
- print error for all invalid index entries.
- new unit test to eval correct error code is set.
- updates the extended header if flags have changed.
- split rbox_mail_storage_try_copy into smaller functions. - fixed: some cpplint issues.
- consistent nameing for rbox_storage, rbox_mailbox, rbox_save_context - removed duplicate code (rbox_append_index)
- renamed RadosMailObject to RadosMail
- renamed rbox_mail->mail_object to rbox_mail->rados_mail - fixed: rbox_storage.cpp formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugfix makes sure that all available mails will be exported if one of the mail objects no longer exist in rados storage.
In short, the solution is to set the error MAIL_ERROR_EXPUNGED for missing mails, in this case, the backup process will ignore this mail and proceed with next mail in index.
Additionally i did some code cleanup.