Feature 2 16 -> code review and merge #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…due to incorrect physical file size and initial access to tmp file, first msg receive will fail
… from rbox-save.c, fixed invalid use of tmail_virtual_size to determine mail size in rados
jrse
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version to save emails to rados and read the mails again.
mails metadata will stay in u.X file
oid is temporarily generated and needs to be replaced
currently i_stream_data is used to hold the rados object after read
read and write from/to rados is synchronous
only rados storage is supported. (file storage will currently lead to error while fetching mail)
Attachments are not supported / tested.
behavior in case of transaction->rollback is undefined
current version is not using the c++ rados class, and code style is not up to date.