Fix some smaller code issues #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Al-Gaaf <[email protected]>
NOTE: There is an issue with simply call build since
librmb is part of the source tree and need to be
installed to build the rest. This will be solved
as soon as librmb is completely separated and then
a dependency for build.
Signed-off-by: Danny Al-Gaaf <[email protected]>
The ret variable need to be signed to be able to handle negative return values from read(). Signed-off-by: Danny Al-Gaaf <[email protected]>
Result of operator '|' is always true if one operand is non-zero. Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
Remove "always true" checks, return error code, cleanup. Signed-off-by: Danny Al-Gaaf <[email protected]>
Signed-off-by: Danny Al-Gaaf <[email protected]>
peter-mauritius
pushed a commit
that referenced
this pull request
Sep 8, 2017
Fix some smaller code issues
peter-mauritius
pushed a commit
that referenced
this pull request
Sep 8, 2017
Fix some smaller code issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.