Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exceptions: change error message for CommandFailedError #1652

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

exceptions: change error message for CommandFailedError #1652

wants to merge 3 commits into from

Commits on Jun 16, 2021

  1. orchestra/run: move Raw and quote to a separate class 

    Class Raw is needed in teuthology.exceptions and importing it from
teuthology.orchestra.run is not possible since it would lead to a
circular dependecy. Move these classes to a new module, run_helper.py,
to avoid this and import through run_helper.py instead.

Signed-off-by: Rishabh Dave <[email protected]>
    @rishabh-d-dave
    rishabh-d-dave committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    54964c8 View commit details
    Browse the repository at this point in the history

  2. exceptions: change error message for CommandFailedError 

    For the convenience of user, print the command that led to
CommandFailedError in error message as a str than as a list or a tuple.
This makes it more readable and enables the user to copy and use the
command without any hassles.

This commit also uses the opportunity to rename the variable "command"
to "cmd" and "self.command" to "self.cmd" in CommandFailedError for
convenience and so that it's easy to keep statements under 80
characters.

Signed-off-by: Rishabh Dave <[email protected]>
    @rishabh-d-dave
    rishabh-d-dave committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    af41a83 View commit details
    Browse the repository at this point in the history

  3. orchestra/run.py: remove spawn_asyncresult() 

    Since the function is dead code, there are no calls to it in teuthology
or ceph repository, remove it.

Signed-off-by: Rishabh Dave <[email protected]>
    @rishabh-d-dave
    rishabh-d-dave committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    c013aa4 View commit details
    Browse the repository at this point in the history