Сonverted all docker-compose files to use build: rather than volumes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dartpopikyardo
commented
Oct 25, 2016
dartpopikyardo
commented
- updated eventuateClientVersion
- updated Int128 usage
…all.sh: use EVENTUATE_LOCAL environment variable
- updated Int128 usage
cer
reviewed
Oct 26, 2016
| @@ -34,7 +35,7 @@ public AccountQueryWorkflow(AccountInfoUpdateService accountInfoUpdateService) { | |||
| public void create(DispatchedEvent<AccountOpenedEvent> de) { | |||
| AccountOpenedEvent event = de.getEvent(); | |||
| String id = de.getEntityId(); | |||
| String eventId = de.getEventId().asString(); | |||
| Int128 eventId = de.getEventId(); | |||
| logger.info("**************** account version=" + id + ", " + eventId); | |||
There was a problem hiding this comment.
@dartpopikyardo No string concatenation when logging. This should be logger.info("... {} ...{}", param1, param2);
pull bot
pushed a commit
to tiarebalbi/event-sourcing-examples
that referenced
this pull request
Nov 3, 2018
pull bot
pushed a commit
to tiarebalbi/event-sourcing-examples
that referenced
this pull request
Nov 3, 2018
…omer * commit '859a01a4bc2372a11a5377d1206235ca12da4417': - fixed tests fix issue cer#24, fix issue cer#26, fix issue cer#27, fix issue cer#28 - added password to CustomerInfo - added unique email constraint to CustomerQuerySide - updated authorization logic removed transferStates from AccountInfo cannot reproduce issue cer#37 Revert "wip-customer small issues fixes"
pull bot
pushed a commit
to tiarebalbi/event-sourcing-examples
that referenced
this pull request
Nov 3, 2018
* wip-customer: Form validation for Sign In & Sign Up Error reporting for Sign In & Sign Up - shouldCreateAccountsAndTransferMoney fix Password on login & registration - fixed tests fix issue cer#24, fix issue cer#26, fix issue cer#27, fix issue cer#28 - added password to CustomerInfo - added unique email constraint to CustomerQuerySide - updated authorization logic removed transferStates from AccountInfo cannot reproduce issue cer#37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.