-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Observable as @Controller return value #4
Conversation
I tried running the tests and got:
|
When I run the tests I get "PLEASE make sure that Event Store-related environment variables including EVENT_STORE_URL are set, see sample-set-remote-env.sh !!!!". I see It sounds like the tests may not be picking up the Theoretically the change is a functionally neutral refactoring if you compare to what is done in |
Thanks for looking into this. The easiest way to test the application without the event store server (i would need to send you credentials) is to run the tests in the monolithic-service module. You could also build the monolithic service and run it 'java -jar' and use curl commands in handy-curl-commands.sh I upgraded to Spring Boot 1.2.3 I had wondered whether This is what i see in the logs
|
Looks like this is harder than I thought. I've created https://jira.spring.io/browse/SPR-13083. I'll send an updated request. |
I've updated the PR. The monolithic-service module test passes now. Note that since the monolithic service imports the web configuration of 3 other web modules (which otherwise probably run independent of each other, right?) it ends up with 3 instances of ObservableReturnValueHandler. It's not ideal but I didn't feel it was necessary to go farther since the monolithic-service is probably there just for illustration purposes. |
For some reason the monolithic test was failing with this error:
I fixed it by using this hack to eliminate the @autowire:
|
@cer and @rstoyanchev to work around ordering issues, couldn't you use Ordered annotation with lowest precedence? |
Pull request for issue #3. I didn't manage to run the examples but the following change should make it possible to return Observable from a controller method.