feat: support json payload #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Mar 25, 2024
src/signing.ts
Outdated
| } | ||
| } | ||
|
|
||
| function replaceCIDs(data: Record<string, any> | any): Record<string, any> | any { |
There was a problem hiding this comment.
might want a data != null at the top here or in isObject (unless TS is doing something I'm unfamiliar with with typeof)
This was referenced May 17, 2024
ukstv
approved these changes
May 20, 2024
ukstv
force-pushed
the
feat/support-json-payload
branch
from
46840fc
to
e5a42d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the codec according to what's described in this forum post
Will need a corresponding change in: