Co-erce non-present values like false to string

cerebris · Apr 20, 2022 · 0e0c4e5 · 0e0c4e5
1 parent dc96280
commit 0e0c4e5
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/lib/jsonapi/resource.rb b/lib/jsonapi/resource.rb
@@ -895,6 +895,13 @@ def is_filter_relationship?(filter)
 
       def verify_filter(filter, raw, context = nil)
         filter_values = []
+        if raw == true
+          raw = "true"
+        elsif raw == false
+          raw = "false"
+        else
+          nil # no-op
+        end
         if raw.present?
           begin
             filter_values += raw.is_a?(String) ? CSV.parse_line(raw) : [raw]

diff --git a/test/unit/resource/resource_test.rb b/test/unit/resource/resource_test.rb
@@ -321,6 +321,18 @@ def test_updatable_fields_does_not_include_id
     assert(!FelineResource.updatable_fields.include?(:id))
   end
 
+  def test_verify_filter
+    resource_klass = PersonResource
+    context = nil
+    filter = :name
+    assert_equal([filter, ["true"]], resource_klass.verify_filter(filter, true, context))
+    assert_equal([filter, ["false"]], resource_klass.verify_filter(filter, false, context))
+    assert_equal([filter, ["true"]], resource_klass.verify_filter(filter, "true", context))
+    assert_equal([filter, ["false"]], resource_klass.verify_filter(filter, "false", context))
+    assert_equal([filter, []], resource_klass.verify_filter(filter, nil, context))
+    assert_equal([filter, []], resource_klass.verify_filter(filter, "", context))
+  end
+
   def test_filter_on_to_many_relationship_id
     posts = PostResource.find(:comments => 3)
     assert_equal([2], posts.map(&:id))