Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use records for joined resources for 0.10 #1381

Merged
merged 7 commits into from
Feb 7, 2022
Merged

Use records for joined resources for 0.10 #1381

merged 7 commits into from
Feb 7, 2022

Conversation

lgebhardt
Copy link
Member

See #1307 for more details

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt requested a review from dgeb February 4, 2022 20:15
@lgebhardt lgebhardt merged commit fa37d64 into release-0-10 Feb 7, 2022
@lgebhardt lgebhardt deleted the use_records_for_joined_resources_0-10 branch February 7, 2022 20:25
@Subtletree Subtletree mentioned this pull request Mar 13, 2022
Closed
JamesGlover pushed a commit to sanger/traction-service that referenced this pull request Apr 28, 2022
Unpin json-api-resource and fix associations
71f17c2 
The update to jsonapi-resources 0.10.6 broke the loading of tubes
for pacbio library and pool resources.

This appears to be related to the addition of the configuration option
`use_related_resource_records_for_joins`

cerebris/jsonapi-resources#1381

This is failing to function correctly in this case.

By specifying the relationship explicitly, we disable this
behaviour, and everything behaves as expected.

I still haven't quite managed to get to the bottom of
the problem. It may be we need to disable the behaviour
globally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgeb dgeb dgeb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lgebhardt @dgeb