-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Bind xclim indicators to missing ECAD indices #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzah
commented
Oct 27, 2022
Whenever the user gives only a year, date_reader would complete the date with the date of the current day. Now we complete with the first of January and show a warning.
@pagecp I've added in the documentation a "how to" recipe for generic indices. It's not fancy but at least it gives an overview of each generic index. See https://icclim--235.org.readthedocs.build/en/235/how_to/recipes_generic.html |
It is really great! It will really help to startup a more full documentation later. And at least current users will be able to use those as examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft how we should bind existing xclim indices into icclim v6 to complete the ECAD list.
Pull Request to resolve #203
doc/source/references/release_notes.rst
.Describe the changes you made
This includes
{GSL, SPI3, SPI6}
.The same approach could be used for other missing indices that can't be generified and that are available within xclim.
This PR is also related to #204 but does not fully resolve it.