Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-navigation-side-menu] Drill-in Custom status display, isLoading #2170

Merged
merged 8 commits into from
May 22, 2024

Conversation

sugan2416
Copy link
Contributor

@sugan2416 sugan2416 commented May 21, 2024

Summary

What was changed:

  • Allow custom node display for status of drill-in content
  • Added isLoading prop for drill-in item to indicate content load.

Why it was changed:

  • Custom display node can be used now, fallback to status-view.
  • IsLoading needed till content load.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10426
UXPLATFORM-10427


Thank you for contributing to Terra.
@cerner/terra

Default status
image

Custom status
image

@github-actions github-actions bot temporarily deployed to preview-pr-2170 May 21, 2024 12:04 Destroyed
@sugan2416 sugan2416 merged commit 1ca9c2e into main May 22, 2024
22 checks passed
@sugan2416 sugan2416 deleted the drill-in-updates branch May 22, 2024 09:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants