Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release-next branch with latest changes in master #1519

Merged
merged 18 commits into from
Jul 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2a513a0
chore: use cm-maintainers in OWNERS file
ThatsMrTalbot Jun 25, 2024
7a450b3
chore: update makefile modules
ThatsMrTalbot Jun 25, 2024
6cd00aa
Merge pull request #1508 from ThatsMrTalbot/chore/use-cm-maintainers-…
cert-manager-prow[bot] Jun 25, 2024
45537c9
add release notes for v1.15.1 and bump latest version
inteon Jun 26, 2024
ff9cb57
fix linter
inteon Jun 26, 2024
781b81c
Merge pull request #1509 from inteon/release_notes_v1.15.1
cert-manager-prow[bot] Jun 26, 2024
911f5d3
bump npm dependencies
inteon Jul 8, 2024
bcf50d0
add support for bash language in prism
inteon Jul 8, 2024
71b8d28
Merge pull request #1511 from inteon/upgrade_npm_dependencies
cert-manager-prow[bot] Jul 8, 2024
abe2726
add redirects for cert-manager.dev, trust-manager.io and trust-manage…
inteon Jul 9, 2024
8ad50e6
Merge pull request #1512 from inteon/add_redirects
cert-manager-prow[bot] Jul 9, 2024
7b7fc26
Fix broken links to Prow command help
erikgb Jul 15, 2024
cfe96fa
Merge pull request #1515 from erikgb/fix-prow-links
cert-manager-prow[bot] Jul 15, 2024
ec8b404
BOT: run 'make upgrade-klone' and 'make generate'
cert-manager-bot Jul 17, 2024
2e08bb9
run 'make upgrade-klone' and 'make generate'
inteon Jul 18, 2024
3121c81
Merge pull request #1510 from cert-manager/self-upgrade-master
cert-manager-prow[bot] Jul 18, 2024
8bdae34
Run 'make upgrade-klone' and 'make generate'
inteon Jul 18, 2024
3c51d44
Merge pull request #1518 from cert-manager/self-upgrade-master
cert-manager-prow[bot] Jul 18, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"eslint:recommended",
"plugin:@next/next/recommended",
"plugin:react/recommended",
"plugin:mdx/recommended",
"plugin:markdown/recommended"
"plugin:mdx/recommended"
],
"parserOptions": {
"ecmaFeatures": {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 20
cache: npm
- run: npm ci
- run: npm run check
17 changes: 13 additions & 4 deletions .github/workflows/make-self-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ on:
schedule:
- cron: '0 0 * * *'

permissions:
contents: read

jobs:
self_upgrade:
runs-on: ubuntu-latest
Expand All @@ -27,13 +30,13 @@ jobs:
echo "This workflow should not be run on a non-branch-head."
exit 1

- uses: actions/checkout@v4
- uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7

- id: go-version
run: |
make print-go-version >> "$GITHUB_OUTPUT"

- uses: actions/setup-go@v5
- uses: actions/setup-go@0a12ed9d6a96ab950c8f026ed9f722fe0da7ef32 # v5.0.2
with:
go-version: ${{ steps.go-version.outputs.result }}

Expand Down Expand Up @@ -64,7 +67,7 @@ jobs:
git push -f origin "$SELF_UPGRADE_BRANCH"

- if: ${{ steps.is-up-to-date.outputs.result != 'true' }}
uses: actions/github-script@v7
uses: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea # v7.0.1
with:
script: |
const { repo, owner } = context.repo;
Expand All @@ -77,7 +80,7 @@ jobs:
});

if (pulls.data.length < 1) {
await github.rest.pulls.create({
const result = await github.rest.pulls.create({
title: '[CI] Merge ' + process.env.SELF_UPGRADE_BRANCH + ' into ' + process.env.SOURCE_BRANCH,
owner: owner,
repo: repo,
Expand All @@ -87,4 +90,10 @@ jobs:
'This PR is auto-generated to bump the Makefile modules.',
].join('\n'),
});
await github.rest.issues.addLabels({
owner,
repo,
issue_number: result.data.number,
labels: ['skip-review']
});
}
13 changes: 10 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,10 @@ FORCE:

noop: # do nothing

# Set empty value for MAKECMDGOALS to prevent the "warning: undefined variable 'MAKECMDGOALS'"
# warning from happening when running make without arguments
MAKECMDGOALS ?=

##################################
# Host OS and architecture setup #
##################################
Expand All @@ -56,8 +60,10 @@ noop: # do nothing
# binary may not be available in the PATH yet when the Makefiles are
# evaluated. HOST_OS and HOST_ARCH only support Linux, *BSD and macOS (M1
# and Intel).
HOST_OS ?= $(shell uname -s | tr A-Z a-z)
HOST_ARCH ?= $(shell uname -m)
host_os := $(shell uname -s | tr A-Z a-z)
host_arch := $(shell uname -m)
HOST_OS ?= $(host_os)
HOST_ARCH ?= $(host_arch)

ifeq (x86_64, $(HOST_ARCH))
HOST_ARCH = amd64
Expand All @@ -70,7 +76,8 @@ endif
# Git and versioning information #
##################################

VERSION ?= $(shell git describe --tags --always --match='v*' --abbrev=14 --dirty)
git_version := $(shell git describe --tags --always --match='v*' --abbrev=14 --dirty)
VERSION ?= $(git_version)
IS_PRERELEASE := $(shell git describe --tags --always --match='v*' --abbrev=0 | grep -q '-' && echo true || echo false)
GITCOMMIT := $(shell git rev-parse HEAD)
GITEPOCH := $(shell git show -s --format=%ct HEAD)
Expand Down
13 changes: 3 additions & 10 deletions OWNERS
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
approvers:
- munnerz
- JoshVanL
- jakexks
- irbekrm
- maelvls
- SgtCoDFish
- wallrj
- inteon
- cm-maintainers
reviewers:
- cm-maintainers
- hawksight
- erikgb
- thatsmrtalbot
- erikgb
1 change: 1 addition & 0 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ aliases:
- irbekrm
- sgtcodfish
- inteon
- thatsmrtalbot
13 changes: 8 additions & 5 deletions components/docs/CodeBlock.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,14 @@
// Zentered 2022, licensed under the Apache 2.0 license.

import React from 'react'
import Highlight, { defaultProps } from 'prism-react-renderer'
import { Highlight, Prism } from 'prism-react-renderer'
import { CopyToClipboard } from 'react-copy-to-clipboard'
import { useState } from 'react'

// see https://github.com/FormidableLabs/prism-react-renderer?tab=readme-ov-file#custom-language-support
(typeof global !== "undefined" ? global : window).Prism = Prism
require('prismjs/components/prism-bash')

const copyIcon = (
<svg
className="docs-codeblock-copy-icon"
Expand Down Expand Up @@ -43,7 +47,6 @@ export default function CodeBlock({ children, theme = 'github' }) {
return (
<div className="relative">
<Highlight
{...defaultProps}
theme={theme}
code={code}
language={language}
Expand All @@ -53,11 +56,11 @@ export default function CodeBlock({ children, theme = 'github' }) {
<CopyToClipboard text={code} onCopy={() => setCopied(doneIcon)}>
<button className="docs-codeblock-btn">{copied}</button>
</CopyToClipboard>
<pre className={`${className}`} style={{ ...style }}>
<pre className={className} style={style}>
{tokens.map((line, i) => (
<div key={i} {...getLineProps({ line, key: i })}>
<div key={i} {...getLineProps({ line })}>
{line.map((token, key) => (
<span key={key} {...getTokenProps({ token, key })} />
<span key={key} {...getTokenProps({ token })} />
))}
</div>
))}
Expand Down
4 changes: 2 additions & 2 deletions content/docs/contributing/contributing-flow.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Any issues towards the documentation should also be filed there.

We use [Prow](https://github.com/k8s-ci-robot/test-infra/tree/master/prow) on all our repositories.
If you've ever looked at a Kubernetes repo, you will probably already have met Prow. Prow will be able to help you in GitHub using its commands.
You can find then all [on the command help page](https://prow.build-infra.jetstack.net/command-help).
You can find then all [on the command help page](https://prow.infra.cert-manager.io/command-help).
Prow will also run all tests and assign certain labels on PRs.

## Bugs
Expand Down Expand Up @@ -159,7 +159,7 @@ Sometimes `/triage` is also added which helps us when following up Issues.
### Assignees meaning in PRs and issues

Sometimes, you might see someone commenting with the
[`/assign` prow command](https://prow.build-infra.jetstack.net/command-help#assign):
[`/assign` prow command](https://prow.infra.cert-manager.io/command-help#assign):

```plain
/assign @meyskens
Expand Down
13 changes: 12 additions & 1 deletion content/docs/releases/release-notes/release-notes-1.15.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,18 @@ Thanks also to the CNCF, which provides resources and support, and to the AWS op

In addition, massive thanks to Venafi for contributing developer time and resources towards the continued maintenance of cert-manager projects.

## Changes by Kind
## `v1.15.1`

### Bug or Regression

- BUGFIX: fix issue that caused Vault issuer to not retry signing when an error was encountered. ([#7111](https://github.com/cert-manager/cert-manager/pull/7111), [@inteon](https://github.com/inteon))

### Other (Cleanup or Flake)

- Update `github.com/Azure/azure-sdk-for-go/sdk/azidentity` to address `CVE-2024-35255` ([#7092](https://github.com/cert-manager/cert-manager/pull/7092), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot))
- Bump the `go-retryablehttp` dependency to fix `CVE-2024-6104` ([#7130](https://github.com/cert-manager/cert-manager/pull/7130), [@SgtCoDFish](https://github.com/SgtCoDFish))

## `v1.15.0`

### Feature

Expand Down
2 changes: 1 addition & 1 deletion content/docs/variables.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"cert_manager_latest_version": "v1.15.0"
"cert_manager_latest_version": "v1.15.1"
}
12 changes: 6 additions & 6 deletions klone.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,30 +10,30 @@ targets:
- folder_name: boilerplate
repo_url: https://github.com/cert-manager/makefile-modules.git
repo_ref: main
repo_hash: e9363accaaee20a995bbf8f1c9cba2ea77da8935
repo_hash: 7200a66ad8f9488094e3ca72b06b9c0768323286
repo_path: modules/boilerplate
- folder_name: generate-verify
repo_url: https://github.com/cert-manager/makefile-modules.git
repo_ref: main
repo_hash: e9363accaaee20a995bbf8f1c9cba2ea77da8935
repo_hash: 7200a66ad8f9488094e3ca72b06b9c0768323286
repo_path: modules/generate-verify
- folder_name: help
repo_url: https://github.com/cert-manager/makefile-modules.git
repo_ref: main
repo_hash: e9363accaaee20a995bbf8f1c9cba2ea77da8935
repo_hash: 7200a66ad8f9488094e3ca72b06b9c0768323286
repo_path: modules/help
- folder_name: klone
repo_url: https://github.com/cert-manager/makefile-modules.git
repo_ref: main
repo_hash: e9363accaaee20a995bbf8f1c9cba2ea77da8935
repo_hash: 7200a66ad8f9488094e3ca72b06b9c0768323286
repo_path: modules/klone
- folder_name: repository-base
repo_url: https://github.com/cert-manager/makefile-modules.git
repo_ref: main
repo_hash: e9363accaaee20a995bbf8f1c9cba2ea77da8935
repo_hash: 7200a66ad8f9488094e3ca72b06b9c0768323286
repo_path: modules/repository-base
- folder_name: tools
repo_url: https://github.com/cert-manager/makefile-modules.git
repo_ref: main
repo_hash: e9363accaaee20a995bbf8f1c9cba2ea77da8935
repo_hash: 7200a66ad8f9488094e3ca72b06b9c0768323286
repo_path: modules/tools
77 changes: 0 additions & 77 deletions lib/github.js

This file was deleted.

2 changes: 1 addition & 1 deletion lib/remark-plugins/variable/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,5 @@ export default function plugin(options) {
break;
}
});
}
};
}
1 change: 1 addition & 0 deletions make/_shared/generate-verify/00_mod.mk
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@
# limitations under the License.

shared_generate_targets ?=
shared_generate_targets_dirty ?=
shared_verify_targets ?=
shared_verify_targets_dirty ?=
12 changes: 9 additions & 3 deletions make/_shared/generate-verify/02_mod.mk
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,24 @@
## Generate all generate targets.
## @category [shared] Generate/ Verify
generate: $$(shared_generate_targets)
@echo "The following targets cannot be run simultaniously with each other or other generate scripts:"
$(foreach TARGET,$(shared_generate_targets_dirty), $(MAKE) $(TARGET))

verify_script := $(dir $(lastword $(MAKEFILE_LIST)))/util/verify.sh

# Run the supplied make target argument in a temporary workspace and diff the results.
verify-%: FORCE
$(verify_script) $(MAKE) -s $*
+$(verify_script) $(MAKE) $*

verify_generated_targets = $(shared_generate_targets:%=verify-%)
verify_generated_targets_dirty = $(shared_generate_targets_dirty:%=verify-%)

verify_targets = $(sort $(verify_generated_targets) $(shared_verify_targets))
verify_targets_dirty = $(sort $(verify_generated_targets_dirty) $(shared_verify_targets_dirty))

.PHONY: verify
## Verify code and generate targets.
## @category [shared] Generate/ Verify
verify: $$(verify_generated_targets) $$(shared_verify_targets)
verify: $$(verify_targets)
@echo "The following targets create temporary files in the current directory, that is why they have to be run last:"
$(MAKE) noop $(shared_verify_targets_dirty)
$(foreach TARGET,$(verify_targets_dirty), $(MAKE) $(TARGET))
2 changes: 1 addition & 1 deletion make/_shared/generate-verify/util/verify.sh
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ cleanup() {
}
trap "cleanup" EXIT SIGINT

cp -a "${projectdir}/." "${tmp}"
rsync -aEq "${projectdir}/." "${tmp}" --exclude "_bin/"
pushd "${tmp}" >/dev/null

"$@"
Expand Down
Loading