Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VC-34401] Update Prometheus metrics documentation to include information about the webhook #1522

Merged

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Jul 18, 2024

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2024
Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae3f425
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager/deploys/669f6a5e0accba0008ed9bd4
😎 Deploy Preview https://deploy-preview-1522--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 19, 2024
@wallrj wallrj force-pushed the webhook-metrics-server branch 4 times, most recently from 6178b89 to 89ddff2 Compare July 19, 2024 15:30
@wallrj wallrj changed the title WIP: [VC-34401] Update Prometheus metrics documentation to include information about the webhook [VC-34401] Update Prometheus metrics documentation to include information about the webhook Jul 19, 2024
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2024
Signed-off-by: Richard Wall <[email protected]>
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@wallrj
Copy link
Member Author

wallrj commented Jul 23, 2024

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@cert-manager-prow cert-manager-prow bot merged commit 93c07ce into cert-manager:release-next Jul 23, 2024
6 of 7 checks passed
@wallrj wallrj deleted the webhook-metrics-server branch July 23, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants