-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for v1.16.0-alpha.0 #1526
Add release notes for v1.16.0-alpha.0 #1526
Conversation
Signed-off-by: Richard Wall <[email protected]>
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
### Feature | ||
|
||
- Add `SecretRef` support for Venafi TPP issuer CA Bundle ([#7036](https://github.com/cert-manager/cert-manager/pull/7036), [`@sankalp-at-gh`](https://github.com/sankalp-at-gh)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, don't feel the need to change anything: I wish we could write release notes that are slightly more user-focused, but I realize that it isn't that easy since each contributor writes their own release notes. Among others:
- Most of these items focus on what was technically done to achieve the feature (e.g., "add X" rather than explaining whether/how it can impact the user.
- "Features" is super heterogenous; I think the Helm improvements should be in their own section or subsection, and maybe also group "Runtime Improvements", and "API Changes".
Example:
- Add
SecretRef
support for Venafi TPP issuer CA Bundle
should be reworded as:
- The Venafi issuer now lets you load your custom CA bundle to connect to TPP from a Secret resource using the new field
secretRef
.
I think we would benefit greatly from having a technical writter look at our release notes from time to time. Maybe we could get @ditatechwriter (Michael) to give some advice on this.
Since this is an alpha, I don't think it's super important to write great release notes. But for the final release, we surely do! I've left a comment in that sense. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c75a056
into
cert-manager:release-next
Preview: https://deploy-preview-1526--cert-manager.netlify.app/docs/releases/release-notes/release-notes-1.16#changes-since-v1150
Part of the v1.16.0-alpha.0 release process.