Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance frontend #35

Merged
merged 27 commits into from
Aug 25, 2023
Merged

feat: enhance frontend #35

merged 27 commits into from
Aug 25, 2023

Conversation

joaodiaslobo
Copy link
Member

This pull request includes enhancements to the UI elements across most pages. The modifications consist of an improved team page UI, better player team UI, a more engaging match page with icons to represent player events, a footer, and mobile responsiveness.

All updates have been made in accordance with the figma design file. Relevant images that showcase the modifications are included below for reference:

image
image
image
image
image

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR in order to get main recent changes.

lib/cesium_cup_web/live/player_live/show.html.heex Outdated Show resolved Hide resolved
lib/cesium_cup_web/live/team_live/show.html.heex Outdated Show resolved Hide resolved
lib/cesium_cup_web/live/match_live/show.html.heex Outdated Show resolved Hide resolved
lib/cesium_cup_web/live/group_live/show.html.heex Outdated Show resolved Hide resolved
lib/cesium_cup_web/live/player_live/show.html.heex Outdated Show resolved Hide resolved
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mix format in order to pass CI

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few changes you'll have to do:
1st - make sure every page design is responsive
2nd - /players could you enhance this page
3rd - please enhance edit pages

@joaodiaslobo joaodiaslobo marked this pull request as draft February 23, 2023 22:02
@joaodiaslobo
Copy link
Member Author

Changed player page to match Figma design.

image

@joaodiaslobo joaodiaslobo changed the title Enhance frontend feat: enhance frontend Aug 23, 2023
@joaodiaslobo joaodiaslobo marked this pull request as ready for review August 23, 2023 16:11
Copy link
Member

@feliciofilipe feliciofilipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🙏

@joaodiaslobo joaodiaslobo enabled auto-merge (squash) August 25, 2023 14:27
@joaodiaslobo joaodiaslobo dismissed MarioRodrigues10’s stale review August 25, 2023 14:30

Some of these changes will only be addressed in future PRs

@joaodiaslobo joaodiaslobo merged commit aac1d14 into main Aug 25, 2023
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/update-frontend branch August 25, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants