Hero #4
Merged
Hero #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GresosJ
requested review from
ruioliveira02,
EnzoVieira,
ruilopesm,
diogogmatos,
afonsopimenta and
MarioRodrigues10
✅ Deploy Preview for cesium-hydrogen ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Still it isnt reponsive because we dont have a design for mobile |
EnzoVieira
reviewed
Jul 25, 2023
app/layout.tsx
Outdated
Comment on lines
19
to
22
| <body className={inter.className}> | ||
| <Navbar /> | ||
| {children} | ||
| </body> |
There was a problem hiding this comment.
Why did you removed the Navbar from the Root Layout?
There was a problem hiding this comment.
I thought it would be better on the page, as there may be pages that don't use the Navbar
There was a problem hiding this comment.
Could you suggest which pages would not make use of the navbar?
There was a problem hiding this comment.
But with the next 13 dont make to much sense what I said
MarioRodrigues10
requested changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.