refactor: change schedule filter to query params #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnzoVieira
requested review from
joaodiaslobo,
Darguima,
ruioliveira02,
tiago-bacelar,
ruilopesm and
MarioRodrigues10
✅ Deploy Preview for seium-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tiago-bacelar
requested changes
Jan 11, 2024
There was a problem hiding this comment.
Hey! I was testing the filters and noticed that when you expand an event the queryParams are reset because of the anchor that is added to the url.
I also noticed that you removed the props.showFilters from the Schedule component, so now both Schedules (both in the landing and in the schedule page) have the filters. This isn't a big issue, but I did have the hope of using the same component for both Speakers and Schedule eventually, and since speakers don't have filters it would make sense to keep it for later, just in case. Idk, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.