Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Mv/ingress version #13

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Mv/ingress version #13

merged 3 commits into from
Nov 16, 2022

Conversation

elmariofredo
Copy link
Contributor

Signed-off-by: Mario Vejlupek [email protected]

What this PR does / why we need it:

  1. migrating Ingress object to networking.k8s.io/v1 as extensions/v1beta1 and networking.k8s.io/v1beta1 are being removed https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
  2. adding className support

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Mario Vejlupek <[email protected]>
Signed-off-by: Mario Vejlupek <[email protected]>
@lapwat
Copy link

lapwat commented Apr 20, 2022

Please merge this fix

@banzo
Copy link
Contributor

banzo commented Oct 3, 2022

@elmariofredo Thank you for the contribution, I think #6 takes care of this issue, so I close the PR. Let me know if I am missing something.

@banzo banzo closed this Oct 3, 2022
@elmariofredo
Copy link
Contributor Author

@banzo sure #6 is good. I wanted to keep backward compatibility, but I don't think that this is relevant at this moment 😉

@banzo banzo reopened this Nov 16, 2022
@banzo
Copy link
Contributor

banzo commented Nov 16, 2022

Reopening for #11

@banzo
Copy link
Contributor

banzo commented Nov 16, 2022

@elmariofredo do you recall why you changed from pathType: Prefix to pathType: ImplementationSpecific?

https://github.com/cetic/helm-adminer/pull/13/conflicts

@toabi
Copy link

toabi commented Nov 16, 2022

Could we merge this? :D I think ImplementationSpecific was the behavior if undefined. I don't see why Prefix wouldn't be the better choice though.

@elmariofredo
Copy link
Contributor Author

@banzo, @toabi I have followed migration notes see https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

pathType is now required for each specified path. Options are Prefix, Exact, and ImplementationSpecific. To match the undefined v1beta1 behavior, use ImplementationSpecific.

Reality is that ImplementationSpecific == Prefix in 99% clusters, but if you want I can change it to Prefix ;)

@banzo banzo merged commit 5596baf into cetic:master Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants