Add support for variables of type string #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for the data type string to the list of support data types, and change the section talking about string variables to describe both character array and string variations.
This was referenced Jul 20, 2018
Removed some unneeded left-single-quote characters.
Added an example showing the two ways to form string-valued variables.
Remove the ambiguous phrase "which has been added to the data variable".
|
@marqh and @JimBiardCics -- I think this is good to merge if you can resolve the conflicts I'll push the button. |
|
@dblodgett-usgs I've got a question. The apph.adoc changes are fine. The history.adoc has the date for this change as the date in 2018 when I did the pull request. Should that be changed to today? |
|
Good question. I'd say update it to today since that's when the changes will actually be applied? |
|
@dblodgett-usgs Do you want to push the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to expand string-valued variables to include variables of type
stringas well as variables of typechar.Fixes #139
See:
http://cf-trac.llnl.gov/trac/ticket/175
#139