Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#393 Whitespace fixes #399

Merged
merged 5 commits into from
Sep 15, 2022
Merged

#393 Whitespace fixes #399

merged 5 commits into from
Sep 15, 2022

Conversation

squaregoldfish
Copy link
Contributor

See issue #393 for discussion of these changes.

  • All trailing whitespace (including conventional spaces and non-standard unicode-style spaces/non-breaking spaces) have been removed.
  • All instances of the tab character have been replaced with two spaces, or an appropriate number to maintain alignment.
  • The file cf-conventions.html has been added to the .gitignore file to reduce the risk of it being accidentally committed.

@squaregoldfish
Add generated cf-conventions.html to .gitignore
b20cfb9 
This means git will ignore it by default, so reduces the risk of accidentally committing it.
@squaregoldfish
Remove trailing whitespaces
940afbc 
Includes non-breaking space characters
@squaregoldfish
Replace tabs with 2 spaces; minor alignment adjustments
5c5876c
@erget
Copy link
Member

erget commented Sep 15, 2022

@squaregoldfish this looks fine to me, except that I agree with your suggestion of adding yourself to conventions_contributors rather than authors (at least for the moment). I've removed you from the author list but can't checkout the repo without having to do some distracting git stuff - would you mind adding yourself to the contributors list?

@squaregoldfish squaregoldfish linked an issue Sep 15, 2022 that may be closed by this pull request
Cut all trailing whitespace including funky unicode characters #393
Closed
@erget erget merged commit f41390c into cf-convention:main Sep 15, 2022
@squaregoldfish squaregoldfish deleted the 393-whitesp branch September 19, 2022 11:18
@davidhassell davidhassell added this to the 1.11 milestone Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erget erget erget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Housekeeping at 2022 workshop
Status: Done
Milestone
1.11
Development

Successfully merging this pull request may close these issues.

Cut all trailing whitespace including funky unicode characters
3 participants
@squaregoldfish @erget @davidhassell