Fixing CF 8.1 refering int types #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,7 @@ The units of a variable should be representative of the unpacked data. | |||
| This standard is more restrictive than the NUG with respect to the use of the **`scale_factor`** and **`add_offset`** attributes; ambiguities and precision problems related to data type conversions are resolved by these restrictions. | |||
| If the **`scale_factor`** and **`add_offset`** attributes are of the same data type as the associated variable, the unpacked data is assumed to be of the same data type as the packed data. | |||
| However, if the **`scale_factor`** and **`add_offset`** attributes are of a different data type from the variable (containing the packed data) then the unpacked data should match the type of these attributes, which must both be of type **`float`** or both be of type **`double`**. | |||
| An additional restriction in this case is that the variable containing the packed data must be of type **`byte`**, **`short`** or **`int`**. | |||
| An additional restriction in this case is that the variable containing the packed data must be of an integer type (see <<data-types>>). | |||
There was a problem hiding this comment.
Hi Antonio, I couldn't find the target of <<data-types>> (apart from in the conformance.adoc, which is not linked in). Do we also need to put an [[data-types]] into ch02.adoc at the Data Types section?
Thanks,
David
|
might be relevant: #374 |
|
Closing this PR because it as been covered by other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue cf-convention/discuss#202 for discussion of these changes.
Complements #244 #294 #243
Release checklist
cf-conventions.adoc?cf-conventions.adocup to date? Versioning inspired by SemVer.history.adocup to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then
mainalways is a draft for the next version.