Convert all referenced URLs with HTTP protocol to HTTPS #476
Conversation
The change was achieved using the shell command: find . -type f -name "*.adoc" | xargs sed -i 's~http://~https://~g' to cover all AsciiDoc files.
The change was achieved using the shell command: find . -type f | xargs sed -i 's~http://~https://~g' under the '.github' directory.
The change was achieved using the shell command: find . -type f -name "*.md" | xargs sed -i 's~http://~https://~g' to cover all Markdown files.
sadielbartholomew
added
the
defect
|
RE the first checklist item, my name is set to be added to the 'additional authors' listing in |
|
I've made the conversion and raised this PR today since time is short before the deadline for getting work in for CF 1.11, but I am yet to double check that all of the new links still work with the HTTPS instead of the HTTP protocol, as Dave Allured has suggested on the linked Issue. I will check each link on Monday and confirm when I have done this (hopefully our link checking workflows can help, but I can always do it manually since there aren't too many to work through with a good coffee...). |
There was a problem hiding this comment.
A self review where I have gone through and checked that all links updated from HTTP to HTTPS still work, as promised last Friday. I have found that all do with the exceptions of (see in-line comments for locations, etc.):
- any links to GeoTIFF pages under the URL root of 'http://geotiff.maptools.org/proj_list/azimuthal_equidistant.html' where the same but starting 'https://' just hangs for me (I tried three cases, no need to go through all for that root);
- two broken links (work with neither protocol).
Given the former, I will update this PR to not set HTTPS for those GeoTiff pages and comment as to why this is an exception to our preference for HTTPS.
|
@larsbarring thanks for looking at this. The PR is now ready for re-review. |
|
Approval to merge given expressed by @larsbarring in #463 (comment) and @JonathanGregory in #463 (comment), so I will now go ahead. Thanks everyone. |
See issue #463 for discussion of these changes.
Release checklist
cf-conventions.adoc?cf-conventions.adocup to date? Versioning inspired by SemVer.history.adocup to date?For maintainers
After the merge remember to delete the source branch.
Tags are set at the conclusion of the annual meeting; until then,
mainalways is a draft for the next version.