#185 tests

cflint · Oct 20, 2016 · 920d663 · 920d663
1 parent 6baa954
commit 920d663
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/src/main/java/com/cflint/CFLint.java b/src/main/java/com/cflint/CFLint.java
@@ -355,7 +355,7 @@ private void process(final Element elem, final String space, final Context conte
 					context.getMessages().clear();
 				} catch (final Exception e) {
 					if (verbose) {
-						e.printStackTrace();
+						;
 					}
 					reportRule(elem, null, context, plugin, PLUGIN_ERROR + exceptionText(e));
 				}

diff --git a/src/main/resources/cflint.definition.json b/src/main/resources/cflint.definition.json
@@ -361,11 +361,13 @@
       "message": [
         {
           "code": "FUNCTION_TYPE_MISSING",
-          "severity": "WARNING"
+          "severity": "WARNING",
+          "messageText": "Function ${variable} return type is missing a return type."
         },
         {
           "code": "FUNCTION_TYPE_ANY",
-          "severity": "INFO"
+          "severity": "INFO",
+          "messageText": "Function ${variable} return type is any. Please change to be the correct type."
         }
       ],
       "parameter": [

diff --git a/src/test/java/com/cflint/TestCFBugs_FunctionType.java b/src/test/java/com/cflint/TestCFBugs_FunctionType.java
@@ -23,7 +23,7 @@ public class TestCFBugs_FunctionType {
 	public void setUp() {
 		final ConfigRuntime conf = new ConfigRuntime();
 		final PluginInfoRule pluginRule = new PluginInfoRule();
-		pluginRule.setName("ArgTypeChecker");
+		pluginRule.setName("FunctionTypeChecker");
 		conf.getRules().add(pluginRule);
 		final PluginMessage pluginMessageMissing = new PluginMessage("FUNCTION_TYPE_MISSING");
 		pluginMessageMissing.setSeverity("WARNING");

diff --git a/src/test/resources/com/cflint/tests/FunctionType/Any/functionany1.expected.txt b/src/test/resources/com/cflint/tests/FunctionType/Any/functionany1.expected.txt
@@ -1,5 +1,5 @@
 [ {
-  "severity" : "WARNING",
+  "severity" : "INFO",
   "id" : "FUNCTION_TYPE_ANY",
   "message" : "FUNCTION_TYPE_ANY",
   "category" : "CFLINT",
@@ -8,10 +8,10 @@
     "file" : "src\\test\\resources\\com\\cflint\\tests\\FunctionType\\Any\\functionany1.cfc",
     "fileName" : "functionany1.cfc",
     "function" : "x",
-    "column" : "0",
+    "column" : "11",
     "line" : "3",
     "message" : "Function x return type is any. Please change to be the correct type.",
-    "variable" : "",
-    "expression" : ""
+    "variable" : "x",
+    "expression" : "public any function x()   {\nx = 123;\n\n  }"
   } ]
 } ]