Ignore VAR_ALL_CAPS for components

[bardware]

Hi,

I have a component that defined constant values I use all over my software; it looks like

<cfcomponent>
    <cfset this.ROOMRESERVATIONS.SINGLE = 1>
    <cfset this.ROOMRESERVATIONS.DOUBLE = 2>

    <cfset this.YES = 1>
    <cfset this.NO = 2>
<cfcomponent>

No that you introduced a syntax to ignore checks on component level, I'd love a way to ignore VAR_ALL_CAPS on component level.

[ryaneberly]

On the component level only? and continue to enforce it at the function level? Like this? <cfcomponent> <cfset this.ROOMRESERVATIONS.SINGLE = 1> <--- Ignore this <cffunction name="test"> <cfset SOMEVAL = 2> <--- flag this </cffunction> <cfcomponent>

…

On Wed, Feb 15, 2017 at 5:04 PM, Bernhard Döbler ***@***.***> wrote: Hi, I have a component that defined constant values I use all over my software; it looks like <cfcomponent> <cfset this.ROOMRESERVATIONS.SINGLE = 1> <cfset this.ROOMRESERVATIONS.DOUBLE = 2> <cfset this.YES = 1> <cfset this.NO = 2> <cfcomponent> No that you introduced a syntax to ignore checks on component level, I'd love a way to ignore VAR_ALL_CAPS on component level. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#239>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFtZu_Ap2lru6ytMk94eYwP69NQ24TTvks5rc3ZogaJpZM4MCTs6> .

[bardware]

Exactly, yes!

[mpaluchowski]

Agree. And not just for the this scope, but also for variables and script syntax :)

component {
  this.SOMECONSTANT = 1;
  SOMEOTHERCONSTANT = 2;
}

[ryaneberly]

I think that means you want to control the message by scope. Sounds good to me.

[ryaneberly]

I added this parameter to VariableNameChecker in cflint.definition.json:
{
"name": "IgnoreAllCapsInScopes",
"value": "this"
}

I suggest we make it ignore ALLCAPS in the 'this' scope by default. What do you think?

[mpaluchowski]

I suggest we make it ignore ALLCAPS in the 'this' scope by default. What do you think?

I would ignore both in this as well as variables. We sometimes use the format to emulate an Enum, where we use this, and sometimes to emulate constants, which usually use variables, unless they should be exposed outside of the class, in which case they use this.

[ryaneberly]

Done. Thanks!

…

On Sat, Mar 4, 2017 at 12:57 AM, Michał Paluchowski < ***@***.***> wrote: I suggest we make it ignore ALLCAPS in the 'this' scope by default. What do you think? I would ignore both in this as well as variables. We sometimes use the format to emulate an Enum, where we use this, and sometimes to emulate constants, which usually use variables, unless they should be exposed outside of the class, in which case they use this. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#239 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFtZu8k1dEhG9r_x7p9rdo3Hn9pfUHNCks5riP1fgaJpZM4MCTs6> .