Unclear error messages: Error in plugin, 0

[mjclemente]

I'm seeing some strange behavior when using 1.1.0, from the master branch (it appears it may be related to use of underscores). I'll do my best to describe it, and provide a screenshot of the resulting output.

I'm including the errors thrown for two files; the same basic two errors are being thrown for each:

• Error in plugin
• 0

For the Error in plugin, the expression referenced is variables._.reverse(categoryList). No expression, line, or function is referenced for the 0 error.

Possibly related to these, I'm also get the following errors:

• Message code: METHOD_ALLCAPS_NAME is not configured correctly."
• Message code: METHOD_TOO_SHORT is not configured correctly.

Is this an issue with my configuration or related to cflint? Thanks for any help or insight you can provide.

(In the first instance, it's a file in which I am using underscoreCFC, and in the second, it's a FW/1 method.

[ryaneberly]

cfparser does not know how to parse the underscore. I will look into that.

[mjclemente]

Thanks! Sorry for the bother; as I've said before, love the project. Let me know if there's anything that I can do to help or clarify further.

[ryaneberly]

No problem at all. Thanks for the continued contributions.

…

On Thu, Jun 1, 2017 at 9:26 PM, Matthew J. Clemente < ***@***.***> wrote: Thanks! Sorry for the bother; as I've said before, love the project. Let me know if there's anything that I can do to help or clarify further. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFtZuyoeRHk_Bq47AE13xVWaOeXPVkhyks5r_2TYgaJpZM4Ng5OA> .

[ryaneberly]

@mjclemente could you test against dev. I cannot duplicate your issue. If you still see it, could you provide a code sample.

[mjclemente]

Sure. Happy to.

When I went to install the dev version, I got a build error:

[INFO]
[INFO] --- maven-war-plugin:2.2:war (default-war) @ CFLint ---
[INFO] Packaging webapp
[INFO] Assembling webapp [CFLint] in [/Users/matthew/www/tools/CFLint-dev/target/CFLint-1.1.0]
[INFO] Processing war project
[INFO] Webapp assembled in [129 msecs]
[INFO] Building war: /Users/matthew/www/tools/CFLint-dev/target/CFLint-1.1.0.war
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 29.029 s
[INFO] Finished at: 2017-06-22T06:36:32-04:00
[INFO] Final Memory: 32M/588M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.2:war (default-war) on project CFLint: Error assembling WAR: webxml attribute is required (or pre-existing WEB-INF/web.xml if executing in update mode) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

I feel like I should probably be able to figure out and correct this, but I'm a complete novice when it comes to Maven. Is there a change I can make to run the build successfully?

[mjclemente]

Sorry, just saw the updated instructions on installing (https://github.com/cflint/CFLint/wiki/How-Do-I-Install-This-Tool%3F). I'll try that route to see if it resolves the issue.

[mjclemente]

Okay, ran the build via Gradle. It says "BUILD SUCCESSFUL" at the end. However, I can't find the executablecflint. (There's no target or appassembler, folders, as there used to be following a Maven install. Not sure how to proceed.

[denuno]

Maven should work again, plus I cut out some loggers that shouldn't be needed and we're causing some extraneous output.

…

-Den

On Jun 22, 2017 9:50 AM, "Matthew J. Clemente" ***@***.***> wrote: Okay, ran the build via Gradle. It says "BUILD SUCCESSFUL" at the end. However, I can't find the executablecflint. (There's no target or appassembler, folders, as there used to be following a Maven install. Not sure how to proceed. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#269 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAL0Yr4VWbjE4EYWBLTOAJPBN_vfufz9ks5sGo1UgaJpZM4Ng5OA> .

[mjclemente]

Thanks. That fixed the build error.

I built CFLint from the latest dev, but the parsing issue is still occurring for me.

I put together some code to reproduce it: https://github.com/mjclemente/cflint-underscore-test

Please let me know if there's more that I can do, or if there's any more information that I can provide.

[ryaneberly]

ValidNames checker has an issue with the underscore. It should be fixed.

[mjclemente]

Awesome! Just downloaded from the dev branch and ran it. Worked perfectly!

Thanks guys; this project is amazing.

[ryaneberly]

@mjclemente . Thanks for testing it.