Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component has too many functions #79

Merged
merged 5 commits into from
Oct 6, 2015
Merged

Component has too many functions #79

merged 5 commits into from
Oct 6, 2015

Conversation

justinmclean
Copy link
Contributor

No description provided.

@ryaneberly
Copy link
Contributor

I would recommend not counting getter/setter functions (start with get* or is* or set* )

And I think by making alreadyTooMany part of the plugin, it will only flag the message once - even if multiple components have the problem.

@justinmclean
Copy link
Contributor Author

New pull request fixes both issues, i.e. ignores trivial functions and reset count when it find a new component. May not be ideal if you have many user function outside of components, so might have to think of a way to deal up with that.

@ryaneberly
Copy link
Contributor

Looks great.

If a user has a "utility" component full of user functions, I would expect them to have an exclude rule that excludes that component from the toomanyfunctions check.

justinmclean added a commit that referenced this pull request Oct 6, 2015
Component has too many functions
@justinmclean justinmclean merged commit fcf24aa into dev Oct 6, 2015
@justinmclean justinmclean deleted the toomanyfunctions branch October 6, 2015 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants