Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/update m-form-field modifiers #8384

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

anselmbradford
Copy link
Member

There are no styles associated with m-form-field__selectable (should be m-form-field--selectable). This was likely added for consistency because we do have m-form-field--checkbox and m-form-field--radio, however, we don't have a modifier for every single type of form input (e.g. text inputs), so it's probably better if we add this back if its needed. There's an argument this could be helpful in the crawler, but in that case the internal select a-select or m-multiselect classes could be queried instead.

Removals

  • Unstyled m-form-field__select class.

Changes

  • Update m-form-field__file-input to m-form-field--file-input because it's a modifier not an element.

How to test this PR

  1. PR checks should pass.

@anselmbradford
Copy link
Member Author

SonarCloud failure is just because I touched files it now sees as duplicate.

@anselmbradford anselmbradford changed the title Remove/update m-form-field modifiers Remove/update m-form-field modifiers May 3, 2024
@anselmbradford anselmbradford added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 61d34e2 May 6, 2024
16 of 17 checks passed
@anselmbradford anselmbradford deleted the ans_remove_formfield branch May 6, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants