Remove/update m-form-field
modifiers
#8384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no styles associated with
m-form-field__selectable
(should bem-form-field--selectable
). This was likely added for consistency because we do havem-form-field--checkbox
andm-form-field--radio
, however, we don't have a modifier for every single type of form input (e.g. text inputs), so it's probably better if we add this back if its needed. There's an argument this could be helpful in the crawler, but in that case the internal selecta-select
orm-multiselect
classes could be queried instead.Removals
m-form-field__select
class.Changes
m-form-field__file-input
tom-form-field--file-input
because it's a modifier not an element.How to test this PR