Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination: Swap order of buttons #8639

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

anselmbradford
Copy link
Member

If you tab through the pagination buttons, the order is wrong.

pagination

With cfpb/design-system#2091, the pagination component uses a grid, so the order can now be corrected and it won't harm the layout.

Changes

  • Swap order of pagination buttons to follow logical tab order.

How to test this PR

  1. Visit /blog and tab to the pagination component and see that the order follows the logical tab order.

Copy link
Member

@contolini contolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order! It's fixed!

@anselmbradford anselmbradford added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 332a8b7 Nov 14, 2024
12 checks passed
@anselmbradford anselmbradford deleted the ans_pagination_order branch November 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants