Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/update m-form-field modifiers #1973

Merged
merged 1 commit into from
May 7, 2024
Merged

Remove/update m-form-field modifiers #1973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions docs/pages/alerts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ variation_groups:
- variation_is_deprecated: false
variation_name: Success
variation_code_snippet: >
<div class="m-form-field m-form-field__success">
<div class="m-form-field">
<input class="a-text-input a-text-input--success" type="text" placeholder="Input text" id="form-input-success" aria-describedby="form-input-success_message">
<div class="a-form-alert a-form-alert--success" id="form-input-success_message" role="alert">
{% include icons/approved-round.svg %}
Expand All @@ -192,8 +192,7 @@ variation_groups:
- variation_is_deprecated: false
variation_name: Warning
variation_code_snippet: >-
<div class="m-form-field m-form-field__warning">

<div class="m-form-field">
<input class="a-text-input a-text-input--warning" type="text" placeholder="Input text" id="form-input-warning" aria-describedby="form-input-warning_message">
<div class="a-form-alert a-form-alert--warning" id="form-input-warning_message" role="alert">
{% include icons/warning-round.svg %}
Expand All @@ -206,7 +205,7 @@ variation_groups:
- variation_is_deprecated: false
variation_name: Error
variation_code_snippet: >-
<div class="m-form-field m-form-field__error">
<div class="m-form-field">
<input class="a-text-input a-text-input--error" type="text" placeholder="Input text" id="form-input-error" aria-describedby="form-input-error_message"><div class="a-form-alert a-form-alert--error" id="form-input-error_message" role="alert">
{% include icons/error-round.svg %}
<span class="a-form-alert__text">
Expand Down
42 changes: 30 additions & 12 deletions docs/pages/checkboxes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ variation_groups:

<!--Success-->

<div class="m-form-field m-form-field--checkbox m-form-field--checkbox__success">
<div class="m-form-field
m-form-field--checkbox
m-form-field--checkbox-success">
<input class="a-checkbox" type="checkbox" id="test_checkbox_success">
<label class="a-label" for="test_checkbox_success">Success</label>
</div>
Expand All @@ -82,7 +84,9 @@ variation_groups:

<!--Warning-->

<div class="m-form-field m-form-field--checkbox m-form-field--checkbox__warning">
<div class="m-form-field
m-form-field--checkbox
m-form-field--checkbox-warning">
<input class="a-checkbox" type="checkbox" id="test_checkbox_warning">
<label class="a-label" for="test_checkbox_warning">Warning</label>
</div>
Expand All @@ -91,7 +95,9 @@ variation_groups:

<!--Error-->

<div class="m-form-field m-form-field--checkbox m-form-field--checkbox__error">
<div class="m-form-field
m-form-field--checkbox
m-form-field--checkbox-error">
<input class="a-checkbox" type="checkbox" id="test_checkbox_error">
<label class="a-label" for="test_checkbox_error">Error</label>
</div>
Expand Down Expand Up @@ -121,8 +127,9 @@ variation_groups:
example, they may not work well for terms of service agreement
checkboxes.
variation_code_snippet: >-
<div class="m-form-field m-form-field--checkbox
m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_default">
<label class="a-label" for="test_checkbox_lg_default">Enabled</label>
</div>
Expand All @@ -132,7 +139,9 @@ variation_groups:

<!--Hover-->

<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox hover" type="checkbox" id="test_checkbox_lg_hover">
<label class="a-label" for="test_checkbox_lg_hover">Hover</label>
</div>
Expand All @@ -142,7 +151,9 @@ variation_groups:

<!--Focus-->

<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox focus" type="checkbox" id="test_checkbox_lg_focus">
<label class="a-label" for="test_checkbox_lg_focus">Focus</label>
</div>
Expand All @@ -153,7 +164,9 @@ variation_groups:

<!--Selected-->

<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_checked" checked>
<label class="a-label" for="test_checkbox_lg_checked">Selected</label>
</div>
Expand All @@ -163,7 +176,9 @@ variation_groups:

<!--Disabled-->

<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_disabled" disabled>
<label class="a-label" for="test_checkbox_lg_disabled">Disabled</label>
</div>
Expand All @@ -175,7 +190,9 @@ variation_groups:

<!--

<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox"
type="checkbox"
id="test_checkbox_lg_disabled"
Expand All @@ -189,8 +206,9 @@ variation_groups:
- variation_is_deprecated: false
variation_name: Large target area checkbox (with helper text)
variation_code_snippet: >-
<div class="m-form-field m-form-field--checkbox
m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="radio" id="test_checkbox_lg_helper">
<label class="a-label" for="test_checkbox_lg_helper">
Label
Expand Down
28 changes: 20 additions & 8 deletions docs/pages/fieldsets.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,19 +78,27 @@ variation_groups:
</legend>
<div class="o-form__group">
<fieldset class="o-form__fieldset">
<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_default_1">
<label class="a-label" for="test_checkbox_lg_default_1">Inline label</label>
</div>
<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_default_2">
<label class="a-label" for="test_checkbox_lg_default_2">Inline label</label>
</div>
<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_default_3">
<label class="a-label" for="test_checkbox_lg_default_3">Inline label</label>
</div>
<div class="m-form-field m-form-field--checkbox m-form-field--lg-target">
<div class="m-form-field
m-form-field--checkbox
m-form-field--lg-target">
<input class="a-checkbox" type="checkbox" id="test_checkbox_lg_default_4">
<label class="a-label" for="test_checkbox_lg_default_4">Inline label</label>
</div>
Expand All @@ -107,25 +115,29 @@ variation_groups:
<small class="a-label__helper a-label__helper--block">Use block helper text for instructions</small>
</legend>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
<div class="m-form-field
m-form-field--radio m-form-field--lg-target">
<input class="a-radio" id="is_helpful_1" type="radio" name="is_helpful" value="1">
<label class="a-label" for="is_helpful_1">Inline label
</label>
</div>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
<div class="m-form-field
m-form-field--radio m-form-field--lg-target">
<input class="a-radio" id="is_helpful_2" type="radio" name="is_helpful" value="0">
<label class="a-label" for="is_helpful_2">Inline label
</label>
</div>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
<div class="m-form-field
m-form-field--radio m-form-field--lg-target">
<input class="a-radio" id="is_helpful_3" type="radio" name="is_helpful" value="0">
<label class="a-label" for="is_helpful_3">Inline label
</label>
</div>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
<div class="m-form-field
m-form-field--radio m-form-field--lg-target">
<input class="a-radio" id="is_helpful_4" type="radio" name="is_helpful" value="0">
<label class="a-label" for="is_helpful_4">Inline label
</label>
Expand Down
6 changes: 4 additions & 2 deletions docs/pages/labels.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@ variation_groups:
<legend class="a-legend">Basic legend
</legend>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
<div class="m-form-field
m-form-field--radio m-form-field--lg-target">
<input class="a-radio" id="is_helpful_1" type="radio" name="is_helpful" value="1">
<label class="a-label" for="is_helpful_1">Inline label
</label>
</div>

<div class="m-form-field m-form-field--radio m-form-field--lg-target">
<div class="m-form-field
m-form-field--radio m-form-field--lg-target">
<input class="a-radio" id="is_helpful_2" type="radio" name="is_helpful" value="0">
<label class="a-label" for="is_helpful_2">Inline label
</label>
Expand Down
20 changes: 10 additions & 10 deletions docs/pages/selects.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ variation_groups:
<!--Enabled state-->


<div class="m-form-field m-form-field__select">
<div class="m-form-field">
<label class="a-label a-label--heading" for="test_select_enabled">
Enabled
</label>
Expand All @@ -33,7 +33,7 @@ variation_groups:

<!--Hover state-->

<div class="m-form-field m-form-field__select">
<div class="m-form-field">
<label class="a-label a-label--heading" for="test_select__hover">
Hover
</label>
Expand All @@ -54,7 +54,7 @@ variation_groups:
<!--Focus state-->


<div class="m-form-field m-form-field__select">
<div class="m-form-field">
<label class="a-label a-label--heading" for="test_select__focus">
Focus
</label>
Expand All @@ -75,7 +75,7 @@ variation_groups:
<!--Disabled state-->


<div class="m-form-field m-form-field__select">
<div class="m-form-field">
<label class="a-label a-label--heading" for="test_select__disabled">Disabled</label>
<div class="a-select a-select--disabled">
<select id="test_select__disabled" disabled>
Expand All @@ -97,7 +97,7 @@ variation_groups:
Allows the user to select multiple items from a dropdown
list of options.
variation_code_snippet: >-
<div class="m-form-field m-form-field__select">
<div class="m-form-field">
<label class="a-label a-label--heading" for="test_select__multiple">
Label
</label>
Expand Down Expand Up @@ -127,16 +127,16 @@ use_cases: >-
Use selects when:


* You have a long list of finite options.
* You have a long list of finite options.

* If the list is shorter than around six items, [radio buttons](https://cfpb.github.io/design-system/components/radio-buttons) or [checkboxes](https://cfpb.github.io/design-system/components/checkboxes) might work better.
* If the list is shorter than around six items, [radio buttons](https://cfpb.github.io/design-system/components/radio-buttons) or [checkboxes](https://cfpb.github.io/design-system/components/checkboxes) might work better.
* If the options include something open ended, a [text input](https://cfpb.github.io/design-system/components/text-inputs) field is better.
* You need structured data for a long list.
* You need structured data for a long list.

* For instance, an open text field for “state” could be entered as Missouri or MO. So if this needs to be standardized, a select facilitates this standardization.
* The list options are familiar to the user.
* The list options are familiar to the user.

* A select is not a good place to introduce new or complicated terms or concepts.
* A select is not a good place to introduce new or complicated terms or concepts.
* For instance, if the question is “What’s your favorite color of the rainbow,” a select could be a good choice. The options are familiar and there are more than six.
accessibility: >-
### Selects
Expand Down
6 changes: 3 additions & 3 deletions packages/cfpb-forms/src/molecules/form-fields.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@
}
}

&--error {
&-error {
.a-label {
&::before {
border-color: @input-border__error;
Expand Down Expand Up @@ -157,7 +157,7 @@
}
}

&--warning {
&-warning {
.a-label {
&::before {
border-color: @input-border__warning;
Expand Down Expand Up @@ -193,7 +193,7 @@
}
}

&--success {
&-success {
.a-label {
&::before {
border-color: @input-border__success;
Expand Down
Loading
Loading