-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate netlify-cms to decap-cms #1980
Conversation
✅ Thanks for the improvements! Browse a preview of your changes using the link below.
To edit notification comments on pull requests, go to your Netlify site configuration. |
55d885f
to
0ad3aa7
Compare
4c3f805
to
2241f67
Compare
001e3ae
to
6fca5b0
Compare
e640ee0
to
79252b4
Compare
79252b4
to
584f972
Compare
656aa90
to
4dd8418
Compare
.frame-content { | ||
padding-left: 20px; | ||
padding-right: 20px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this entire file be deleted now that decap.scss
exists? And import it in main.scss
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm yes indeed d842395
import { StringTrimmedControl } from './widgets/StringTrimmed.js'; | ||
import { StringWithInstructionsControl } from './widgets/StringWithInstructions.js'; | ||
import genericPreviewTemplate from './widgets/genericPreviewTemplate.js'; | ||
import navigationPreviewTemplate from './widgets/navigationPreviewTemplate.js'; | ||
import pagePreviewTemplate from './widgets/pagePreviewTemplate.js'; | ||
|
||
CMS.init(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that we need to initialize the CMS when the docs state that it's only necessary when the CMS_MANUAL_INIT
flag is enabled. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is weird! But if I remove it the CMS screen is a blank screen 🤷
3e31a9f
to
e045b46
Compare
e045b46
to
1b24686
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
netlify-cms has migrated to decap-cms https://www.netlify.com/blog/netlify-cms-to-become-decap-cms/
Changes
Testing
yarn start
should run a local server at localhost:4000/design-system, where you can edit pages.