Update: add data-order to nav button (#61)

[kirsty-hames]

Fixes #61

Update

Hard code data-order as this won't need to be configurable. As it's a development tool, it makes sense this is last in the nav order (alongside any other development/review tools).

The original issue notes that manually adding the data-order had no effect on the nav order however this worked as expected for me. See screen shot below.

[swashbuck]

👍

I think we can go ahead and remove the .u-float-right style for the button? Or is that there for backwards compatibility before the nav container nav__inner used flexbox?

[kirsty-hames]

I think we can go ahead and remove the .u-float-right style for the button? Or is that there for backwards compatibility before the nav container nav__inner used flexbox?

Good spot @swashbuck, I hadn't noticed. Having looked into this, .u-float-right has been removed from all adaptlearning nav button/elements except languagePicker, but most cgkineo plugins still include this. Seeing as data-order takes precedence over CSS float I'm fine to leave this in for legacy. Then again, not sure if these have been left in for legacy reasons or just forgotten about so equally fine to remove if we want to tidy up?

[swashbuck]

I think we can go ahead and remove the .u-float-right style for the button? Or is that there for backwards compatibility before the nav container nav__inner used flexbox?

Good spot @swashbuck, I hadn't noticed. Having looked into this, .u-float-right has been removed from all adaptlearning nav button/elements except languagePicker, but most cgkineo plugins still include this. Seeing as data-order takes precedence over CSS float I'm fine to leave this in for legacy. Then again, not sure if these have been left in for legacy reasons or just forgotten about so equally fine to remove if we want to tidy up?

@kirsty-hames Thanks for doing that research. Maybe this can be a separate cleanup issue where we update all CGKineo buttons at once? If most adaptlearning nav buttons have had .u-float-right removed, then it's most likely an oversight on the CGKineo buttons.

[kirsty-hames]

I think we can go ahead and remove the .u-float-right style for the button? Or is that there for backwards compatibility before the nav container nav__inner used flexbox?

Good spot @swashbuck, I hadn't noticed. Having looked into this, .u-float-right has been removed from all adaptlearning nav button/elements except languagePicker, but most cgkineo plugins still include this. Seeing as data-order takes precedence over CSS float I'm fine to leave this in for legacy. Then again, not sure if these have been left in for legacy reasons or just forgotten about so equally fine to remove if we want to tidy up?

@kirsty-hames Thanks for doing that research. Maybe this can be a separate cleanup issue where we update all CGKineo buttons at once? If most adaptlearning nav buttons have had .u-float-right removed, then it's most likely an oversight on the CGKineo buttons.

Sounds good to me @swashbuck. I'll remove in this instance and raise issues for the other plugins.

[swashbuck]

👍

[github-actions]

🎉 This PR is included in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀