Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: add data-order to nav button (#61) #80

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Update: add data-order to nav button (#61) #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
88d2170
hard code nav btn data-order
kirsty-hames Mar 13, 2024
744e24c
remove redundant comment regarding nav btn rendering position
kirsty-hames Mar 13, 2024
8b66330
remove legacy nav btn float
kirsty-hames Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion js/adapt-devtools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,6 @@ class DevtoolsNavigationView extends Backbone.View {
$('html').addClass('devtools-enabled').toggleClass('devtools-extended', Adapt.devtools.get('_extended'));
if (this.$el.is('a') || this.$el.is('button')) this.$el.on('click', this.onDevtoolsClicked.bind(this));
else this.$el.find('a, button').on('click', this.onDevtoolsClicked.bind(this));
// keep drawer item to left of PLP, resources, close button etc
this.listenTo(Adapt, 'pageView:postRender menuView:postRender', this.onContentRendered);
// ensure render occurs at least once (_isReady will not change to true on menus that exclude content objects)
this.listenToOnce(Adapt, 'pageView:postRender menuView:postRender', this.render);
Expand Down
4 changes: 0 additions & 4 deletions less/devtools.less
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
.devtools {
// Nav icons
// --------------------------------------------------
&__nav-btn {
.u-float-right;
}

&__nav-btn .icon {
.icon-cog;
}
Expand Down
2 changes: 1 addition & 1 deletion templates/devtoolsNavigation.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<button class="btn-icon nav__btn nav__devtools-btn devtools__nav-btn">
<button class="btn-icon nav__btn nav__devtools-btn devtools__nav-btn" data-order="9000">
<span class="icon" aria-hidden="true"></span>
</button>